Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task

From	Ingo Molnar <mingo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task
Date	2016-11-24 06:00 +0100
Message-ID	<sGUiB-65P-7@gated-at.bofh.it> (permalink)
References	<sDHhT-2vk-7@gated-at.bofh.it> <sDHhU-2vk-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Viresh Kumar <viresh.kumar@linaro.org> wrote:

> +	/*
> +	 * For Real Time and Deadline tasks, schedutil governor shoots the
> +	 * frequency to maximum. And special care must be taken to ensure that
> +	 * this kthread doesn't result in that.
> +	 *
> +	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> +	 * updated only at the end of the sugov_work() and before that schedutil
> +	 * rejects all other frequency scaling requests.
> +	 *
> +	 * Though there is a very rare case where the RT thread yields right
> +	 * after the work_in_progress flag is cleared. The effects of that are
> +	 * neglected for now.
> +	 */

s/schedutil governor/
  the schedutil governor

s/And special care must be taken/
  Special care must be taken

s/at the end of the sugov_work()/
  at the end of the sugov_work() function

s/before that schedutil rejects/
  before the schedutil governor rejects

s/Though there is a very rare case where
  There is a very rare case though, where

Thanks,

	Ingo

Thread

[PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
  [PATCH V2 2/4] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
  [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
    Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Ingo Molnar <mingo@kernel.org> - 2016-11-24 06:00 +0100
      Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 07:20 +0100
        Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Ingo Molnar <mingo@kernel.org> - 2016-11-24 07:30 +0100
  [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
    Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Peter Zijlstra <peterz@infradead.org> - 2016-11-16 16:30 +0100
      Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-24 02:20 +0100
    Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Ingo Molnar <mingo@kernel.org> - 2016-11-24 06:00 +0100
      Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 06:20 +0100
  Re: [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Steve Muckle <smuckle.linux@gmail.com> - 2016-11-24 04:10 +0100
    Re: [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 05:10 +0100

csiph-web