Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1528910

Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task

Show all headers | View raw

On Wednesday, November 16, 2016 04:26:05 PM Peter Zijlstra wrote:
> On Tue, Nov 15, 2016 at 01:53:22PM +0530, Viresh Kumar wrote:
> > @@ -308,7 +313,21 @@ static void sugov_irq_work(struct irq_work *irq_work)
> >  	struct sugov_policy *sg_policy;
> >  
> >  	sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
> > +
> > +	/*
> > +	 * For Real Time and Deadline tasks, schedutil governor shoots the
> > +	 * frequency to maximum. And special care must be taken to ensure that
> > +	 * this kthread doesn't result in that.
> > +	 *
> > +	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> > +	 * updated only at the end of the sugov_work() and before that schedutil
> > +	 * rejects all other frequency scaling requests.
> > +	 *
> > +	 * Though there is a very rare case where the RT thread yields right
> > +	 * after the work_in_progress flag is cleared. The effects of that are
> > +	 * neglected for now.
> > +	 */
> > +	kthread_queue_work(&sg_policy->worker, &sg_policy->work);
> >  }
> 
> 
> Right, so that's a wee bit icky, but its also entirely pre-existing
> code.
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Whole series applied.

Thanks,
Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
  [PATCH V2 2/4] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
  [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
    Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Ingo Molnar <mingo@kernel.org> - 2016-11-24 06:00 +0100
      Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 07:20 +0100
        Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Ingo Molnar <mingo@kernel.org> - 2016-11-24 07:30 +0100
  [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
    Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Peter Zijlstra <peterz@infradead.org> - 2016-11-16 16:30 +0100
      Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-24 02:20 +0100
    Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Ingo Molnar <mingo@kernel.org> - 2016-11-24 06:00 +0100
      Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 06:20 +0100
  Re: [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Steve Muckle <smuckle.linux@gmail.com> - 2016-11-24 04:10 +0100
    Re: [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 05:10 +0100

csiph-web