Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1522434

[PATCH V2 2/4] cpufreq: schedutil: enable fast switch earlier

Show all headers | View raw

The fast_switch_enabled flag will be used by both sugov_policy_alloc()
and sugov_policy_free() with a later patch.

Prepare for that by moving the calls to enable and disable it to the
beginning of sugov_init() and end of sugov_exit().

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 kernel/sched/cpufreq_schedutil.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 8c4e1652e895..68f21bb6bd44 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -416,9 +416,13 @@ static int sugov_init(struct cpufreq_policy *policy)
 	if (policy->governor_data)
 		return -EBUSY;
 
+	cpufreq_enable_fast_switch(policy);
+
 	sg_policy = sugov_policy_alloc(policy);
-	if (!sg_policy)
-		return -ENOMEM;
+	if (!sg_policy) {
+		ret = -ENOMEM;
+		goto disable_fast_switch;
+	}
 
 	mutex_lock(&global_tunables_lock);
 
@@ -456,8 +460,6 @@ static int sugov_init(struct cpufreq_policy *policy)
 
 out:
 	mutex_unlock(&global_tunables_lock);
-
-	cpufreq_enable_fast_switch(policy);
 	return 0;
 
 fail:
@@ -468,6 +470,10 @@ static int sugov_init(struct cpufreq_policy *policy)
 	mutex_unlock(&global_tunables_lock);
 
 	sugov_policy_free(sg_policy);
+
+disable_fast_switch:
+	cpufreq_disable_fast_switch(policy);
+
 	pr_err("initialization failed (error %d)\n", ret);
 	return ret;
 }
@@ -478,8 +484,6 @@ static void sugov_exit(struct cpufreq_policy *policy)
 	struct sugov_tunables *tunables = sg_policy->tunables;
 	unsigned int count;
 
-	cpufreq_disable_fast_switch(policy);
-
 	mutex_lock(&global_tunables_lock);
 
 	count = gov_attr_set_put(&tunables->attr_set, &sg_policy->tunables_hook);
@@ -490,6 +494,7 @@ static void sugov_exit(struct cpufreq_policy *policy)
 	mutex_unlock(&global_tunables_lock);
 
 	sugov_policy_free(sg_policy);
+	cpufreq_disable_fast_switch(policy);
 }
 
 static int sugov_start(struct cpufreq_policy *policy)
-- 
2.7.1.410.g6faf27b

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
  [PATCH V2 2/4] cpufreq: schedutil: enable fast switch earlier Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
  [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only used in slow path Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
    Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Ingo Molnar <mingo@kernel.org> - 2016-11-24 06:00 +0100
      Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 07:20 +0100
        Re: [PATCH V2 4/4] cpufreq: schedutil: irq-work and mutex are only  used in slow path Ingo Molnar <mingo@kernel.org> - 2016-11-24 07:30 +0100
  [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-15 09:30 +0100
    Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Peter Zijlstra <peterz@infradead.org> - 2016-11-16 16:30 +0100
      Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-11-24 02:20 +0100
    Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Ingo Molnar <mingo@kernel.org> - 2016-11-24 06:00 +0100
      Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 06:20 +0100
  Re: [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Steve Muckle <smuckle.linux@gmail.com> - 2016-11-24 04:10 +0100
    Re: [PATCH V2 0/4] cpufreq: schedutil: move slow path from workqueue  to SCHED_FIFO task Viresh Kumar <viresh.kumar@linaro.org> - 2016-11-24 05:10 +0100

csiph-web