Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402635

Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker

Show all headers | View raw

Hi Vivek,

Sorry for the delay in getting back to you.


> What't the underlying fs you are using. overlayfs requires underlying
> filesystem to support d_type and there were cases where xfs was
> built with ftype=0 and in that case xfs does not support d_type. That
> means it led to issues like whiteouts not being recognized and being
> left behind during various operations.

I'm using ext4 as the backing filesystem for Docker.

However, if I manually mount an overlay directly on the ext4 fs, it
works just fine.

Therefore, I suspect the problem arises through some magic Docker is
doing. I think it is layering overlays and may be doing that in some
weird way.

I'm hopefully going to get some more time to spend on this problem (and
on that machine) today. As soon as I can unpick what Docker is doing
I'll post more details.

Regards,
Daniel

>
> So it became clear that we need a check at mount time to make sure
> d_type is supported otherwise error out. This will require users to
> do mkfs.xfs with ftype=1 to make progress.
>
> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
> not sure which version that change was made in.
>
> Thanks
> Vivek
>
>> Reverting 45aebeaf4f67 ("ovl: Ensure upper filesystem supports d_type")
>> fixes the issue for me. I haven't investigated the root cause yet - at a
>> guess I'd say either Docker's layering system, or some weird interaction
>> with namespacing, maybe? I'll have a look when I get a spare moment.
>> 
>> For reference, I'm using docker 1.11.0-dev.
>> 
>> Regards,
>> Daniel Axtens

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker  Daniel Axtens <dja@axtens.net> - 2016-05-16 08:50 +0200
  Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-16 15:10 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-17 08:30 +0200
      Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <mszeredi@redhat.com> - 2016-05-17 10:20 +0200
        Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-17 14:20 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <miklos@szeredi.hu> - 2016-05-17 16:30 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 05:40 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 00:40 +0200

csiph-web