Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker

From	Miklos Szeredi <mszeredi@redhat.com>
Newsgroups	linux.kernel
Subject	Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker
Date	2016-05-17 10:20 +0200
Message-ID	<rzIop-252-11@gated-at.bofh.it> (permalink)
References	<rzkvM-3ws-9@gated-at.bofh.it> <rzqrv-7tO-3@gated-at.bofh.it> <rzGFX-XB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, May 17, 2016 at 8:28 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Mon, May 16, 2016 at 09:07:27AM -0400, Vivek Goyal wrote:
>> So it became clear that we need a check at mount time to make sure
>> d_type is supported otherwise error out. This will require users to
>> do mkfs.xfs with ftype=1 to make progress.
>>
>> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
>> not sure which version that change was made in.
>
> Dumb question - can we end up with empty workdir at that point?  Because
> if we do, the check would appear to return a false negative, no matter
> what fs supports...

ovl_workdir_create() creates a subdirectory of workdir ("work") so
workdir itself won't be empty after that.  If somebody else messes
with workdir, then we are screwed anyway.

Thanks,
Miklos

Thread

45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker  Daniel Axtens <dja@axtens.net> - 2016-05-16 08:50 +0200
  Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-16 15:10 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-17 08:30 +0200
      Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <mszeredi@redhat.com> - 2016-05-17 10:20 +0200
        Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-17 14:20 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <miklos@szeredi.hu> - 2016-05-17 16:30 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 05:40 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 00:40 +0200

csiph-web