Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402708

Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker

Show all headers | View raw

Hi Vivek,

My sincere apologies - it turns out I *was* running on xfs with
ftype=0. Someone in the office had moved docker's storage without
me noticing.

Apologies to all whose time I wasted.

Regards,
Daniel

Vivek Goyal <vgoyal@redhat.com> writes:

> On Tue, May 17, 2016 at 10:15:21AM +0200, Miklos Szeredi wrote:
>> On Tue, May 17, 2016 at 8:28 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>> > On Mon, May 16, 2016 at 09:07:27AM -0400, Vivek Goyal wrote:
>> >> So it became clear that we need a check at mount time to make sure
>> >> d_type is supported otherwise error out. This will require users to
>> >> do mkfs.xfs with ftype=1 to make progress.
>> >>
>> >> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
>> >> not sure which version that change was made in.
>> >
>> > Dumb question - can we end up with empty workdir at that point?  Because
>> > if we do, the check would appear to return a false negative, no matter
>> > what fs supports...
>> 
>> ovl_workdir_create() creates a subdirectory of workdir ("work") so
>> workdir itself won't be empty after that.  If somebody else messes
>> with workdir, then we are screwed anyway.
>
> Right. Initially I was creating a directory of my own and later realized
> that ovl_workdir_create() already creates one.
>
> Having said that, what happens when ovl_workdir_create() fails and we
> mount overlayfs read only. In that case I think we will conclude that
> underlying fs does not support d_type and mounting will fail.
>
> Any thoughts, on how to handle this failure path better?
>
> Daniel,
>
> Yesterday Eric Sandeen told me that I can run "xfs_info <mount-point>" to
> figure out if ftype is 0 or 1. You might want to run "xfs_info /" and 
> ensure ftype=0 in your case and overlay is not detecting it wrong.
>
> Thanks
> Vivek

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker  Daniel Axtens <dja@axtens.net> - 2016-05-16 08:50 +0200
  Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-16 15:10 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-17 08:30 +0200
      Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <mszeredi@redhat.com> - 2016-05-17 10:20 +0200
        Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-17 14:20 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <miklos@szeredi.hu> - 2016-05-17 16:30 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 05:40 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 00:40 +0200

csiph-web