Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!goblin1!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Daniel Axtens <dja@axtens.net>
Newsgroups	linux.kernel
Subject	Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker
Date	Wed, 18 May 2016 00:40:01 +0200
Message-ID	<rzVOF-23T-3@gated-at.bofh.it> (permalink)
References	<rzkvM-3ws-9@gated-at.bofh.it> <rzqrv-7tO-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=IVVQVKnbcMtGxwbTubaxE5n+WRqY6g9849QUunxuyVk=; b=ZNnWxOTqZ9ETz3N+sUw0drN90j3nKONayI0T5CwCpbKQ15bSmbsuu3+MD+maT7oRor Qc2ik287/V1rprj87C691qRyDvsE5CpDZvWg4hb0q/VdpjU+6O+nbAlP9eMdZoITmRBC s3yd+RfmmToB3SdhykNK90yGm+p6dXe6aXAG0=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=IVVQVKnbcMtGxwbTubaxE5n+WRqY6g9849QUunxuyVk=; b=Xb32okTlDRsA8LMDQHFBAJHfUC7eOLCQe39zlOww7N6eDKVEyRn1lJOOrkLCiy4GQp abZNOl+/HFcmJe84vSe4fTC7+ebGJfjDf5Vih7ofpjoFAMbjZs0m2lWYAFGHMtna6h4N L9hfhOanGwx4wWAN/TXZX/J46IUAVarK+nOFwk/vlQH2iHTJv/gbAIPLh2cO5IEzGWJP EB/1dt2buePbFT2K0Ia9P4nKF8/Mx6VPxA2jQwsk9q3G+YQ/zLFRiuYsv+f7wL1PlsQU 9XrUWUOdvu7//QBzgtjjgZrSDXQq6tZ5UmnfjBaFsSrQIFSWklDhxjlQo/Uh3/LxdleN yv8A==
X-Gm-Message-State	AOPr4FWtDOciL82ri9mpNzhHxtUMm3hbmrF25fu660zH8hIhuF1s39paNIdWKACwADHpLg==
X-Received	by 10.98.89.28 with SMTP id n28mr5702783pfb.41.1463524754524; Tue, 17 May 2016 15:39:14 -0700 (PDT)
User-Agent	Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	linux-fsdevel@vger.kernel.org, linux-unionfs@vger.kernel.org, linux-kernel@vger.kernel.org, mpe@ellerman.id.au, mszeredi@redhat.com, dchinner@redhat.com
X-Original-Date	Wed, 18 May 2016 08:39:08 +1000
X-Original-Message-ID	<87k2is71ir.fsf@gamma.ozlabs.ibm.com>
X-Original-References	<87d1ombix6.fsf@gamma.ozlabs.ibm.com> <20160516130727.GA26411@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1402635

Show key headers only | View raw

Hi Vivek,

Sorry for the delay in getting back to you.


> What't the underlying fs you are using. overlayfs requires underlying
> filesystem to support d_type and there were cases where xfs was
> built with ftype=0 and in that case xfs does not support d_type. That
> means it led to issues like whiteouts not being recognized and being
> left behind during various operations.

I'm using ext4 as the backing filesystem for Docker.

However, if I manually mount an overlay directly on the ext4 fs, it
works just fine.

Therefore, I suspect the problem arises through some magic Docker is
doing. I think it is layering overlays and may be doing that in some
weird way.

I'm hopefully going to get some more time to spend on this problem (and
on that machine) today. As soon as I can unpick what Docker is doing
I'll post more details.

Regards,
Daniel

>
> So it became clear that we need a check at mount time to make sure
> d_type is supported otherwise error out. This will require users to
> do mkfs.xfs with ftype=1 to make progress.
>
> I think new defaults for mkfs.xfs are such that ftype=1 is set. I am
> not sure which version that change was made in.
>
> Thanks
> Vivek
>
>> Reverting 45aebeaf4f67 ("ovl: Ensure upper filesystem supports d_type")
>> fixes the issue for me. I haven't investigated the root cause yet - at a
>> guess I'd say either Docker's layering system, or some weird interaction
>> with namespacing, maybe? I'll have a look when I get a spare moment.
>> 
>> For reference, I'm using docker 1.11.0-dev.
>> 
>> Regards,
>> Daniel Axtens

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker  Daniel Axtens <dja@axtens.net> - 2016-05-16 08:50 +0200
  Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-16 15:10 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Al Viro <viro@ZenIV.linux.org.uk> - 2016-05-17 08:30 +0200
      Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <mszeredi@redhat.com> - 2016-05-17 10:20 +0200
        Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Vivek Goyal <vgoyal@redhat.com> - 2016-05-17 14:20 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type"  breaking Docker Miklos Szeredi <miklos@szeredi.hu> - 2016-05-17 16:30 +0200
          Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 05:40 +0200
    Re: 45aebeaf4f67 "ovl: Ensure upper filesystem supports d_type" breaking Docker Daniel Axtens <dja@axtens.net> - 2016-05-18 00:40 +0200

csiph-web