[PATCH 1/1] net: rsi: eliminate superfluous NULL check

From	Heinrich Schuchardt <xypron.glpk@gmx.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] net: rsi: eliminate superfluous NULL check
Date	2016-05-18 00:40 +0200
Message-ID	<rzVOF-23T-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

msg is dereferenced before checking against NULL, e.g.
when assigning pad_bytes.
Remove the superfluous check in function rsi_mgmt_pkt_to_core.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 40658b6..35c14cc 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -398,7 +398,7 @@ static int rsi_mgmt_pkt_to_core(struct rsi_common *common,
 			return -ENOLINK;
 
 		msg_len -= pad_bytes;
-		if ((msg_len <= 0) || (!msg)) {
+		if (msg_len <= 0) {
 			rsi_dbg(MGMT_RX_ZONE,
 				"%s: Invalid rx msg of len = %d\n",
 				__func__, msg_len);
-- 
2.1.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] net: rsi: eliminate superfluous NULL check Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-05-18 00:40 +0200
  Re: [PATCH 1/1] net: rsi: eliminate superfluous NULL check David Miller <davem@davemloft.net> - 2016-05-19 20:40 +0200

csiph-web