Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1551004 > unrolled thread

Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA  binding Florian Fainelli <f.fainelli@gmail.com> - 2017-01-04 18:30 +0100
    Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-04 18:40 +0100
      Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA  binding Andrew Lunn <andrew@lunn.ch> - 2017-01-04 18:50 +0100
        Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-04 19:00 +0100
    Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-05 14:00 +0100

#1551004 — Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
> Hi Florian,
>  
>  On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>> dsa: Document new binding"). The legacy binding node is kept included, but is
>> marked disabled.
>>
> 
> I tested this patch on mvebu/dt (I needed to reduce the context to apply
> the patch due to the changes made by Russell King on this file). I also
> set the status of the old binding to "disable" (instead of "okay").

Yes, that needs fixing, thanks for mentioning that.

> 
> It seems to work with the limited test did:
> ifconfig eth1 up
> udhcpc -i lan1
> iperf -c mylaptop
> 
> (same for lan4)
> 
> However is there a way to be sure that the new binding is used?

The best way is probably to make sure that your switch device appears
parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
Alternatively, if you see a message like:

DSA: switch 0 0 parsed

in your dmesg, that would also be indicative of using the new binding
and corresponding code.

Thanks a lot for trying that out!
-- 
Florian

[toc] | [next] | [standalone]

#1551024 — Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

Hi Florian, All,

Florian Fainelli <f.fainelli@gmail.com> writes:

>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.

That makes me think that we should either remove, or use different
values for the version described in net/dsa/dsa.c:

    char dsa_driver_version[] = "0.1";

Today this is absolutely useless and erroneous.

Thanks,

        Vivien

[toc] | [prev] | [next] | [standalone]

#1551027

> That makes me think that we should either remove, or use different
> values for the version described in net/dsa/dsa.c:
> 
>     char dsa_driver_version[] = "0.1";
> 
> Today this is absolutely useless and erroneous.

I think it has been useless for over 9 years.

Feel free to remove it.

     Andrew

[toc] | [prev] | [next] | [standalone]

#1551038 — Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> That makes me think that we should either remove, or use different
>> values for the version described in net/dsa/dsa.c:
>> 
>>     char dsa_driver_version[] = "0.1";
>> 
>> Today this is absolutely useless and erroneous.
>
> I think it has been useless for over 9 years.

Do we want to get rid of it, or do we want to have a string version per
DSA implementation? (old vs. new bindings).

I don't like the actual way to distinguish between the two (grep'ing
dmesg as Florian shown). Maybe a pr_info in dsa2.c would be enough to
inform about DSA "v2". What do you guys prefer?

Thanks,

        Vivien

[toc] | [prev] | [next] | [standalone]

#1551959 — Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

Hi Florian,
 
 On mer., janv. 04 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:

> On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
>> Hi Florian,
>>  
>>  On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> 
>>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>>> dsa: Document new binding"). The legacy binding node is kept included, but is
>>> marked disabled.
>>>
>> 
>> I tested this patch on mvebu/dt (I needed to reduce the context to apply
>> the patch due to the changes made by Russell King on this file). I also
>> set the status of the old binding to "disable" (instead of "okay").
>
> Yes, that needs fixing, thanks for mentioning that.
>
>> 
>> It seems to work with the limited test did:
>> ifconfig eth1 up
>> udhcpc -i lan1
>> iperf -c mylaptop
>> 
>> (same for lan4)
>> 
>> However is there a way to be sure that the new binding is used?
>
> The best way is probably to make sure that your switch device appears
> parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
> Alternatively, if you see a message like:
>
> DSA: switch 0 0 parsed
>
> in your dmesg, that would also be indicative of using the new binding
> and corresponding code.

So it's OK I had this message.

Gregory


>
> Thanks a lot for trying that out!
> -- 
> Florian

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web