Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
Date	2017-01-04 19:00 +0100
Message-ID	<sVY0V-7Sy-7@gated-at.bofh.it> (permalink)
References	(1 earlier) <sV0xP-6m-15@gated-at.bofh.it> <sVXxT-7HR-23@gated-at.bofh.it> <sVXxT-7HR-21@gated-at.bofh.it> <sVXHB-7LF-61@gated-at.bofh.it> <sVXRf-7OT-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

>> That makes me think that we should either remove, or use different
>> values for the version described in net/dsa/dsa.c:
>> 
>>     char dsa_driver_version[] = "0.1";
>> 
>> Today this is absolutely useless and erroneous.
>
> I think it has been useless for over 9 years.

Do we want to get rid of it, or do we want to have a string version per
DSA implementation? (old vs. new bindings).

I don't like the actual way to distinguish between the two (grep'ing
dmesg as Florian shown). Maybe a pr_info in dsa2.c would be enough to
inform about DSA "v2". What do you guys prefer?

Thanks,

        Vivien

Thread

Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA  binding Florian Fainelli <f.fainelli@gmail.com> - 2017-01-04 18:30 +0100
  Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-04 18:40 +0100
    Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA  binding Andrew Lunn <andrew@lunn.ch> - 2017-01-04 18:50 +0100
      Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-04 19:00 +0100
  Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-05 14:00 +0100

csiph-web