Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding
Date	2017-01-04 18:30 +0100
Message-ID	<sVXxT-7HR-21@gated-at.bofh.it> (permalink)
References	<sV0xP-6m-3@gated-at.bofh.it> <sV0xP-6m-15@gated-at.bofh.it> <sVXxT-7HR-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/04/2017 09:23 AM, Gregory CLEMENT wrote:
> Hi Florian,
>  
>  On lun., janv. 02 2017, Florian Fainelli <f.fainelli@gmail.com> wrote:
> 
>> Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net:
>> dsa: Document new binding"). The legacy binding node is kept included, but is
>> marked disabled.
>>
> 
> I tested this patch on mvebu/dt (I needed to reduce the context to apply
> the patch due to the changes made by Russell King on this file). I also
> set the status of the old binding to "disable" (instead of "okay").

Yes, that needs fixing, thanks for mentioning that.

> 
> It seems to work with the limited test did:
> ifconfig eth1 up
> udhcpc -i lan1
> iperf -c mylaptop
> 
> (same for lan4)
> 
> However is there a way to be sure that the new binding is used?

The best way is probably to make sure that your switch device appears
parented to the MDIO bus driver under /sys/class/mdio_bus/*mvmdio*.
Alternatively, if you see a message like:

DSA: switch 0 0 parsed

in your dmesg, that would also be indicative of using the new binding
and corresponding code.

Thanks a lot for trying that out!
-- 
Florian

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA  binding Florian Fainelli <f.fainelli@gmail.com> - 2017-01-04 18:30 +0100
  Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-04 18:40 +0100
    Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA  binding Andrew Lunn <andrew@lunn.ch> - 2017-01-04 18:50 +0100
      Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2017-01-04 19:00 +0100
  Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-05 14:00 +0100

csiph-web