Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1726337
| From | Nicolin Chen <nicoleotsuka@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq |
| Date | 2017-09-05 07:10 +0200 |
| Message-ID | <umehz-6TH-1@gated-at.bofh.it> (permalink) |
| References | <ulAWR-7Ee-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Sep 03, 2017 at 01:05:01PM +0200, Lukasz Majewski wrote:
> The problem is visible in the following setup (on the imx6q):
> "simple-audio-card" -> ssi2 -> I2S + I2C -> codec
>
> The function call log (simple-card probe -> CONFIG_SND_SIMPLE_CARD):
>
> asoc_simple_card_init_dai() @ sound/soc/generic/simple-card-utils.c
> snd_soc_dai_set_sysclk()
> fsl_ssi_set_dai_sysclk() @ sound/soc/fsl/fsl_ssi.c
>
> The last call is changing the bit clock (BCLK) frequency to SSI's IP
> block clock (ipg = 66 MHz) [1].
I think a bigger question here is why the routine sets BCLK to 66MHz.
> This is wrong, since IMX SSI block requires the I2S BCLK to be less
> than 1/5 of [1].
>
> As a result the driver initialization passes without any errors, but the
> speaker-test test case breaks.
>
> This commit checks if the fsl_ssi_set_dai_sysclk() frequency passed is
> not equal to [1].
I don't feel it's quite comprehensive...what if it's being set to 67MHz.
Thanks
Nicolin
> Signed-off-by: Lukasz Majewski <lukma@denx.de>
> ---
> sound/soc/fsl/fsl_ssi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 173cb84..1186fa9 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -809,6 +809,8 @@ static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
> int clk_id, unsigned int freq, int dir)
> {
> struct fsl_ssi_private *ssi_private = snd_soc_dai_get_drvdata(cpu_dai);
> + if (clk_get_rate(ssi_private->clk) == freq)
> + return 0;
>
> ssi_private->bitclk_freq = freq;
>
> --
> 2.1.4
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski <lukma@denx.de> - 2017-09-03 13:10 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-03 16:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-03 17:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:30 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 20:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 01:00 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 11:30 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 19:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 20:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 21:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 23:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-08 01:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 02:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-06 01:30 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 10:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-05 22:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:10 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 09:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 10:00 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Mark Brown <broonie@kernel.org> - 2017-09-05 17:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 19:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Mark Brown <broonie@kernel.org> - 2017-09-07 15:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 01:10 +0200
csiph-web