Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727238
| From | Łukasz Majewski <lukma@denx.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq |
| Date | 2017-09-06 10:50 +0200 |
| Message-ID | <umEc2-7zV-7@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <umeAV-70c-1@gated-at.bofh.it> <umhyO-kE-17@gated-at.bofh.it> <umqC6-6kM-7@gated-at.bofh.it> <umtqh-8fp-9@gated-at.bofh.it> <umvs5-1bc-5@gated-at.bofh.it> |
| Organization | DENX |
Hi Fabio,
> On Tue, Sep 5, 2017 at 6:13 PM, Łukasz Majewski <lukma@denx.de> wrote:
>
>> &i2c1 {
>> clock-frequency = <400000>;
>> pinctrl-names = "default";
>> pinctrl-0 = <&pinctrl_i2c1>;
>> status = "okay";
>>
>> codec: tfa9879@6C {
>> #sound-dai-cells = <0>;
>> compatible = "tfa9879";
>
> This codec seems to miss device tree support. Don't you need something
> like this?
>
> --- a/sound/soc/codecs/tfa9879.c
> +++ b/sound/soc/codecs/tfa9879.c
> @@ -312,9 +312,15 @@ static const struct i2c_device_id tfa9879_i2c_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, tfa9879_i2c_id);
>
> +static const struct of_device_id tfa9879_of_match[] = {
> + { .compatible = "nxp,tfa9879", },
> + { }
> +};
> +
> static struct i2c_driver tfa9879_i2c_driver = {
> .driver = {
> .name = "tfa9879",
> + .of_match_table = tfa9879_of_match,
> },
> .probe = tfa9879_i2c_probe,
> .remove = tfa9879_i2c_remove,
>
Maybe it should be added, but the driver is probed via I2C "node" in dts.
I took the codec (tfa9879) driver as-is.
--
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski <lukma@denx.de> - 2017-09-03 13:10 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-03 16:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-03 17:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:30 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 20:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 01:00 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 11:30 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 19:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 20:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 21:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 23:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-08 01:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 02:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-06 01:30 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 10:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-05 22:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:10 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 09:40 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 10:00 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Mark Brown <broonie@kernel.org> - 2017-09-05 17:20 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 19:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Mark Brown <broonie@kernel.org> - 2017-09-07 15:50 +0200
Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 01:10 +0200
csiph-web