Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

From	jeffy <jeffy.chen@rock-chips.com>
Newsgroups	linux.kernel
Subject	Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru
Date	2017-09-05 06:30 +0200
Message-ID	<umdES-6pB-13@gated-at.bofh.it> (permalink)
References	<uhSpj-1JA-3@gated-at.bofh.it> <ukbnQ-rR-23@gated-at.bofh.it> <ukeF4-2E4-25@gated-at.bofh.it> <um8ca-2S5-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Heiko,

On 09/05/2017 06:33 AM, Heiko Stübner wrote:
> Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy:
>> On 08/30/2017 09:30 PM, Heiko Stübner wrote:
>>>>> -		compatible = "realtek,rt5514";
>>>>> +		compatible = "realtek,rt5514", "realtek,rt5514-i2c";
>>>
>>> the rt5514-i2c and -spi compatibles should be documented in the
>>> binding-txt
>>> of the chip, but I haven't found any mention of this.
>>>
>>>
>>> Heiko
>>
>> these compatibles are only used for our snd driver to detect rt5514 i2c
>> driver and rt5514 spi driver, suggested by Matthias at
>> https://patchwork.kernel.org/patch/9904731/
>>
>> should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding
>> document?
>
> You're introducing new bindings for the codec, so they should of course
> part of the rt5514 binding.
ok, will do that.
and it looks like there's no binding for rt5514-spi, will add it too :)
>
>
> Heiko
>
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru Heiko Stübner <heiko@sntech.de> - 2017-08-30 15:40 +0200
  Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices'  compatible for Gru jeffy <jeffy.chen@rock-chips.com> - 2017-08-30 19:10 +0200
    Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru Heiko Stübner <heiko@sntech.de> - 2017-09-05 00:40 +0200
      Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices'  compatible for Gru jeffy <jeffy.chen@rock-chips.com> - 2017-09-05 06:30 +0200

csiph-web