Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728490

Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

From Łukasz Majewski <lukma@denx.de>
Newsgroups linux.kernel
Subject Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq
Date 2017-09-08 01:20 +0200
Message-ID <unefv-6Pb-1@gated-at.bofh.it> (permalink)
References (6 earlier) <umuZ3-IG-15@gated-at.bofh.it> <umEOJ-85j-1@gated-at.bofh.it> <umMCB-53y-3@gated-at.bofh.it> <umNoZ-5Br-9@gated-at.bofh.it> <umOuK-6gq-19@gated-at.bofh.it>
Organization DENX

Show all headers | View raw

Hi Nicolin,

> On Wed, Sep 06, 2017 at 08:35:50PM +0200, Łukasz Majewski wrote:
>   
>> 	clocks = <&clks IMX6QDL_CLK_SSI2_IPG>,
>> 		 <&clks IMX6QDL_CLK_SSI2>;
>> 	clock-names = "ipg", "baud";
> 
>>>>   			dailink_master: cpu {
>>>>   			    sound-dai = <&ssi2>;
>>>> 			    clock = <&SSSS>;
>>
>> 	If possible I do prefer a solution, which uses only DTS.
>> Side question - how to refer to baud clock from [1]?
> 
> Just add a property to this cpu node like:
> 	clock = <&clks IMX6QDL_CLK_SSI2>;

This doesn't solve the issue:

root@display5:~# speaker-test

speaker-test 1.1.3

Playback device is default
Stream parameters are 48000Hz, S16_LE, 1 channels
Using 16 octaves of pink noise
Rate set to 48000Hz (requested 48fsl-ssi-dai 202c000.ssi: bitclk > ipgclk/5
000Hz)
Buffer size range from 64fsl-ssi-dai 202c000.ssi: ASoC: can't set 
202c000.ssi hw params: -22
  to 65536
Period size range from 32 to 8191
Using max buffer size 65536
Periods = 4
Unable to set hw params for playback: Invalid argument
Setting of hwparams failed: Invalid argument


> 
>>>> 			    system-clock-frequency = <XXXX>;
> 
> This would not be necessary unless you want to specify a clock rate
> so as to override the clock rate configuration in hw_params().
> 
>>> This is the right solution based on current simple-card driver. For
>>> SSI (having two clocks), you have to specify the baud clock in the
>>> cpu node like that. I believe this is what the simple-card designer
>>> expected users to do since the cpu node is the first place that the
>>> driver tries to look at.
>>
>> I will give a shoot the option with adding the ipg clock.
> 
> No, not ipg clock. You should use the second clock -- baud clock.
> 


-- 
Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski <lukma@denx.de> - 2017-09-03 13:10 +0200
  Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-03 16:50 +0200
    Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-03 17:40 +0200
    Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:30 +0200
      Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:40 +0200
        Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 20:20 +0200
          Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
            Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 01:00 +0200
              Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 11:30 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 19:50 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 20:40 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 21:50 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 23:20 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-08 01:20 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 02:40 +0200
            Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-06 01:30 +0200
              Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 10:50 +0200
        Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-05 22:20 +0200
          Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
  Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:10 +0200
    Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 09:40 +0200
      Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 10:00 +0200
        Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:20 +0200
          Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Mark Brown <broonie@kernel.org> - 2017-09-05 17:20 +0200
            Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 19:50 +0200
              Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Mark Brown <broonie@kernel.org> - 2017-09-07 15:50 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 01:10 +0200

csiph-web