Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq

From	Nicolin Chen <nicoleotsuka@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq
Date	2017-09-08 01:10 +0200
Message-ID	<une5Q-6M2-13@gated-at.bofh.it> (permalink)
References	(3 earlier) <umgW5-8kA-9@gated-at.bofh.it> <umhfs-el-19@gated-at.bofh.it> <umnNU-4n9-17@gated-at.bofh.it> <umq93-5S4-11@gated-at.bofh.it> <un5lU-wK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Sep 07, 2017 at 02:44:11PM +0100, Mark Brown wrote:
 
> > On the other hand, the sys clock (baudclk in the driver) should be
> > configured whenever it's related to external clock outputs. When I
> > implemented this set_sysclk() for fsl_ssi.c, I used it to set this
> > sys clock (baudclk) by a machine driver, in order to set bit clock.
> > Then someone patched the driver by moving all the code to set_bclk()
> > to make machine drivers simpler. Now the set_sysclk() is remained
> > to give machine drivers a chance to override clock configurations
> > in the hw_params(). This could be used in TDM or some other special
> > cases (It could also have a purpose for backwards compatibility).
> 
> > So here, we should set baudclk (BCLK generator).
> 
> No, that's just going to cause confusion - if all the other drivers are
> using set_sysclk() to set an input clock rate to the IP rather than an
> output clock but your driver does something else then sooner or later
> someone will run into trouble with that.  

I admit I had that concern. Probably I should have deprecated this
set_sysclk(). I will try to patch it and hw_params() accordingly.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq Lukasz Majewski <lukma@denx.de> - 2017-09-03 13:10 +0200
  Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-03 16:50 +0200
    Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-03 17:40 +0200
    Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:30 +0200
      Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:40 +0200
        Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 20:20 +0200
          Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
            Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 01:00 +0200
              Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 11:30 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 19:50 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 20:40 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-06 21:50 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 23:20 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-08 01:20 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 02:40 +0200
            Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-06 01:30 +0200
              Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-06 10:50 +0200
        Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Fabio Estevam <festevam@gmail.com> - 2017-09-05 22:20 +0200
          Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 23:20 +0200
  Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 07:10 +0200
    Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 09:40 +0200
      Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 10:00 +0200
        Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Łukasz Majewski <lukma@denx.de> - 2017-09-05 10:20 +0200
          Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Mark Brown <broonie@kernel.org> - 2017-09-05 17:20 +0200
            Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-05 19:50 +0200
              Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Mark Brown <broonie@kernel.org> - 2017-09-07 15:50 +0200
                Re: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal  to system freq Nicolin Chen <nicoleotsuka@gmail.com> - 2017-09-08 01:10 +0200

csiph-web