Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.

From	Alex Deucher <alexdeucher@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D.
Date	2017-04-24 16:30 +0200
Message-ID	<tzNa3-87g-53@gated-at.bofh.it> (permalink)
References	(1 earlier) <txGPn-1wE-7@gated-at.bofh.it> <txQ2l-7Bg-1@gated-at.bofh.it> <ty23w-6o6-27@gated-at.bofh.it> <ty3Ci-7ov-21@gated-at.bofh.it> <tyPGV-3bv-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 21, 2017 at 6:53 PM, Eric Anholt <eric@anholt.net> wrote:
> Daniel Vetter <daniel@ffwll.ch> writes:
>
>> On Wed, Apr 19, 2017 at 7:55 PM, Eric Anholt <eric@anholt.net> wrote:
>>> Daniel Vetter <daniel@ffwll.ch> writes:
>>>> On Tue, Apr 18, 2017 at 9:11 PM, Eric Anholt <eric@anholt.net> wrote:
>>>>> The FBDEV initialization would throw an error in dmesg, when we just
>>>>> want to silently not initialize fbdev on a V3D-only VC4 instance.
>>>>>
>>>>> Signed-off-by: Eric Anholt <eric@anholt.net>
>>>>
>>>> Hm, this shouldn't be an error really, you might want to hotplug more
>>>> connectors later on. What exactly complains?
>>>
>>> drm_fb_helper_init() throws an error if the passed in connector count is
>>> 0, so drm_fb_cma_helper() printks an error.
>>
>> Oh, _that_ thing. The error in there is correct, but (almost) everyone
>> gets this parameter wrong. This isn't the max number of connectors the
>> fb helper will light up, but just the max number of connectors _per_
>> crtc when driving in hw clone mode. There's two problems with that:
>> - fb helpers don't support hw clone mode, we select 1:1 crtcs for each
>> active connector
>> - I mentioned that everyone gets this wrong?
>>
>> If you're moderately bored it'd be great to nuke the max_connector
>> argument from drm_fb_helper_init, and hard-code it to 1 (with a big
>> comment explaining that this needs to be changed, probably with
>> dynamic reallocation, once someone gets around to implementing hw
>> clone mode).
>>
>> If you're less bored, just hardcode this to 1 in vc4 and done. Plus a
>> TODO.rst entry would be great in that case.
>
> If I'm driving a GPU with no display subsystem at all, it seems like I
> shouldn't initialize fbdev for it, right?

That's what we do for radeon/amdgpu on hw without display blocks.

Alex

Thread

[PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
  [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
    Re: [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus. Rob Herring <robh@kernel.org> - 2017-04-20 22:40 +0200
  [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
    Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-04-19 07:10 +0200
      Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-19 20:00 +0200
        Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-04-19 21:40 +0200
          Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-22 01:00 +0200
            Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Alex Deucher <alexdeucher@gmail.com> - 2017-04-24 16:30 +0200
              Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-05-02 10:20 +0200
  Re: [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-18 21:30 +0200
  [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 01:40 +0200
    Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 01:50 +0200
      Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 02:10 +0200
      Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 02:10 +0200
      [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-24 22:20 +0200
        Re: [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Rob Herring <robh@kernel.org> - 2017-04-28 20:30 +0200
          Re: [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-28 23:50 +0200

csiph-web