Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1625559

[PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus.

From Eric Anholt <eric@anholt.net>
Newsgroups linux.kernel
Subject [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus.
Date 2017-04-18 21:20 +0200
Message-ID <txGPn-1wE-3@gated-at.bofh.it> (permalink)
References <txGPn-1wE-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Cygnus has V3D 2.6 instead of 2.1, and doesn't use the VC4 display
modules.  The V3D can be uniquely identified by the IDENT[01]
registers, and there's nothing to key off of for the display change
other than the lack of DT nodes for the display components, but it's
convention to have new compatible strings anyway.

Signed-off-by: Eric Anholt <eric@anholt.net>
---
 Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt | 4 ++--
 drivers/gpu/drm/vc4/vc4_drv.c                              | 1 +
 drivers/gpu/drm/vc4/vc4_v3d.c                              | 1 +
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
index bc1756f4f791..284e2b14cfbe 100644
--- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
+++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt
@@ -5,7 +5,7 @@ with HDMI output and the HVS (Hardware Video Scaler) for compositing
 display planes.
 
 Required properties for VC4:
-- compatible:	Should be "brcm,bcm2835-vc4"
+- compatible:	Should be "brcm,bcm2835-vc4" or "brcm,cygnus-vc4"
 
 Required properties for Pixel Valve:
 - compatible:	Should be one of "brcm,bcm2835-pixelvalve0",
@@ -54,7 +54,7 @@ Required properties for VEC:
 		  See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
 
 Required properties for V3D:
-- compatible:	Should be "brcm,bcm2835-v3d"
+- compatible:	Should be "brcm,bcm2835-v3d" or "brcm,cygnus-v3d"
 - reg:		Physical base address and length of the V3D's registers
 - interrupts:	The interrupt number
 		  See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c
index 92fb9a41fe7c..754ce76d4b98 100644
--- a/drivers/gpu/drm/vc4/vc4_drv.c
+++ b/drivers/gpu/drm/vc4/vc4_drv.c
@@ -335,6 +335,7 @@ static int vc4_platform_drm_remove(struct platform_device *pdev)
 
 static const struct of_device_id vc4_of_match[] = {
 	{ .compatible = "brcm,bcm2835-vc4", },
+	{ .compatible = "brcm,cygnus-vc4", },
 	{},
 };
 MODULE_DEVICE_TABLE(of, vc4_of_match);
diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c
index 2442622e6bff..3abcd27aa46f 100644
--- a/drivers/gpu/drm/vc4/vc4_v3d.c
+++ b/drivers/gpu/drm/vc4/vc4_v3d.c
@@ -304,6 +304,7 @@ static int vc4_v3d_dev_remove(struct platform_device *pdev)
 
 static const struct of_device_id vc4_v3d_dt_match[] = {
 	{ .compatible = "brcm,bcm2835-v3d" },
+	{ .compatible = "brcm,cygnus-v3d" },
 	{ .compatible = "brcm,vc4-v3d" },
 	{}
 };
-- 
2.11.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
  [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
    Re: [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus. Rob Herring <robh@kernel.org> - 2017-04-20 22:40 +0200
  [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
    Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-04-19 07:10 +0200
      Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-19 20:00 +0200
        Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-04-19 21:40 +0200
          Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-22 01:00 +0200
            Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Alex Deucher <alexdeucher@gmail.com> - 2017-04-24 16:30 +0200
  Re: [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-18 21:30 +0200
  [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 01:40 +0200
    Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 01:50 +0200
      Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 02:10 +0200
      Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 02:10 +0200
      [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-24 22:20 +0200

csiph-web