Re: [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime.

From	Eric Anholt <eric@anholt.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime.
Date	2017-04-18 21:30 +0200
Message-ID	<txGZ3-1zP-9@gated-at.bofh.it> (permalink)
References	<txGPn-1wE-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Eric Anholt <eric@anholt.net> writes:

> For the Raspberry Pi's bindings, the power domain also implicitly
> turns on the clock and deasserts reset, but for the new Cygnus port we
> start representing the clock in the devicetree.

> +	v3d->clk = devm_clk_get(dev, "v3d_clk");
> +	if (IS_ERR(v3d->clk)) {
> +		int ret = PTR_ERR(v3d->clk);
> +
> +		if (ret == -ENODEV) {

Apparently I hadn't booted this on RPi yet.  This is supposed to be
-ENOENT.

> +			/* bcm2835 didn't have a clock reference in the DT. */
> +			ret = 0;
> +			v3d->clk = NULL;
> +		} else {
> +			if (ret != -EPROBE_DEFER)
> +				dev_err(dev, "Failed to get V3D clock: %d\n",
> +					ret);
> +			return ret;
> +		}
> +	}

Thread

[PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
  [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
    Re: [PATCH 3/3] drm/vc4: Add specific compatible strings for Cygnus. Rob Herring <robh@kernel.org> - 2017-04-20 22:40 +0200
  [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-18 21:20 +0200
    Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-04-19 07:10 +0200
      Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-19 20:00 +0200
        Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Daniel Vetter <daniel@ffwll.ch> - 2017-04-19 21:40 +0200
          Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only bound to V3D. Eric Anholt <eric@anholt.net> - 2017-04-22 01:00 +0200
            Re: [PATCH 2/3] drm/vc4: Don't try to initialize FBDEV if we're only  bound to V3D. Alex Deucher <alexdeucher@gmail.com> - 2017-04-24 16:30 +0200
  Re: [PATCH 1/3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-18 21:30 +0200
  [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 01:40 +0200
    Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Florian Fainelli <f.fainelli@gmail.com> - 2017-04-19 01:50 +0200
      Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 02:10 +0200
      Re: [PATCH 1/3 v2] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-19 02:10 +0200
      [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Eric Anholt <eric@anholt.net> - 2017-04-24 22:20 +0200

csiph-web