Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628122

Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date 2017-04-21 12:50 +0200
Message-ID <tyEiu-4Kp-11@gated-at.bofh.it> (permalink)
References (5 earlier) <ty0XN-5M7-35@gated-at.bofh.it> <tyqfv-4Br-1@gated-at.bofh.it> <tyqSe-537-21@gated-at.bofh.it> <tyE8O-4Ha-23@gated-at.bofh.it> <tyE8O-4Ha-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Apr 21, 2017 at 12:39:30PM +0200, Takashi Iwai wrote:
> Jose Abreu wrote:

> > Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
> > called "dwc") and let the module still be called "designware-i2s"?

> Lubomir's patch keeps the module name intact.  My point is that rename
> of a file isn't nice to look at the git commit history, so it's better
> to be avoided as much as possible.  But in this case, it looks
> unavoidable.

Right.  Renaming the source file is the lesser evil, it's possible
people might have the module name in their configuration for their
systems somewhere.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 13:10 +0200
  Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 17:20 +0200
    Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 18:20 +0200
      Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 19:20 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-19 18:20 +0200
          Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:50 +0200
            Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-20 21:50 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-20 22:30 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building  designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-20 22:30 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-21 12:40 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-21 12:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-21 12:40 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:20 +0200

csiph-web