Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1625392

Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date 2017-04-18 17:20 +0200
Message-ID <txD57-7Jd-3@gated-at.bofh.it> (permalink)
References <txzbb-5tz-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Apr 18, 2017 at 12:59:54PM +0200, Lubomir Rintel wrote:
> It makes not sense: the whether the PIO PCM extension is used is
> hardcoded to the designware_i2s driver and designware_pcm doesn't
> have any module metadata, causing a kernel taint:
> 
>   [   44.287000] designware_pcm: module license 'unspecified' taints kernel.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>

This is not a a good approach, there is no technical reason to force the
driver to be built in.  If you need a license tag in the module then add
that.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 13:10 +0200
  Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 17:20 +0200
    Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 18:20 +0200
      Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 19:20 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-19 18:20 +0200
          Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:50 +0200
            Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-20 21:50 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-20 22:30 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building  designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-20 22:30 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-21 12:40 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-21 12:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-21 12:40 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:20 +0200

csiph-web