Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module

From	Jose Abreu <Jose.Abreu@synopsys.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date	2017-04-19 18:20 +0200
Message-ID	<ty0uK-5Cb-13@gated-at.bofh.it> (permalink)
References	<txzbb-5tz-1@gated-at.bofh.it> <txD57-7Jd-3@gated-at.bofh.it> <txE1c-8hy-11@gated-at.bofh.it> <txEXf-ok-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Lubomir,


On 18-04-2017 18:15, Mark Brown wrote:
> On Tue, Apr 18, 2017 at 06:13:30PM +0200, Lubomir Rintel wrote:
>
>> I don't think designware_pcm is a separate driver. It looks tightly
>> coupled with designware_i2s: you can either disable designware_pcm
>> altogether at build time or always load it together with
>> designware_i2s.
> Yes, they're closely coupled but we might still want them both as a
> module.

Thanks for the patch but I agree with Mark.

For the record you can add "MODULE_LICENSE(“Dual MIT/GPL”)".

Best regards,
Jose Miguel Abreu

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 13:10 +0200
  Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 17:20 +0200
    Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 18:20 +0200
      Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 19:20 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-19 18:20 +0200
          Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:50 +0200
            Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-20 21:50 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-20 22:30 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building  designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-20 22:30 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-21 12:40 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-21 12:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-21 12:40 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:20 +0200

csiph-web