Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1628121

Re: [PATCH v3] Staging: most: use __func__ instead of the function name

Show all headers | View raw

On Fri, 2017-04-21 at 00:40 -0700, Chandra Annamaneni wrote:
> Third Reminder. Please review.

Patience.

> On Sun, 9 Apr 2017, chandrasekhar annamaneni wrote:
> > Second reminder, please review.
[]
> > On Fri, Mar 17, 2017 at 12:49 PM, Chandra Annamaneni <chandra627@gmail.com>
> > wrote:
> > 
> >       Change video.c to use %s, __func__ instead of function names.
> >       Warnings flagged by checkpatch.pl
[]
> >       diff --git a/drivers/staging/most/aim-v4l2/video.c
[]
> >       @@ -79,7 +79,7 @@ static int aim_vdev_open(struct file *filp)
> >               struct most_video_dev *mdev = video_drvdata(filp);
> >               struct aim_fh *fh;
> > 
> >       -       v4l2_info(&mdev->v4l2_dev, "aim_vdev_open()\n");
> >       +       v4l2_info(&mdev->v4l2_dev, "%s()\n", __func__);

More likely all of these should be deleted
as these seem to be function tracing logging
and ftrace works well.

see: Documentation/trace/ftrace.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-21 09:50 +0200
  Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Greg KH <greg@kroah.com> - 2017-04-21 10:50 +0200
    Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Chandra Annamaneni <chandra627@gmail.com> - 2017-04-21 20:20 +0200
      Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Greg KH <greg@kroah.com> - 2017-04-21 20:30 +0200
  Re: [PATCH v3] Staging: most: use __func__ instead of the function  name Joe Perches <joe@perches.com> - 2017-04-21 12:40 +0200

csiph-web