Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module
Date	2017-04-20 22:30 +0200
Message-ID	<tyqSe-537-25@gated-at.bofh.it> (permalink)
References	(4 earlier) <ty0uK-5Cb-13@gated-at.bofh.it> <ty0uJ-5Cb-11@gated-at.bofh.it> <ty0XN-5M7-35@gated-at.bofh.it> <tyqfv-4Br-1@gated-at.bofh.it> <tyqSe-537-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Apr 20, 2017 at 10:24:14PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > I think forcing this to be built in to the kernel (which is what the
> > commit message says the change is going to do) is an obviously bad
> > idea.  Anything we add to the base kernel image needs to have a good
> > reason to be there and it is hard to think what that reason might be for
> > any audio driver, we need to be able to put this code into a module.

> Well, I guess the original patch description caused a big confusion.
> As far as I see, the intention of the patch is not about the module or
> built-in kernel.  Instead it's rather to fold designware_pcm stuff
> into the single designware_i2s driver.

Ah, right.  That'd be fine.

Thread

[PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 13:10 +0200
  Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 17:20 +0200
    Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-18 18:20 +0200
      Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-18 19:20 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Lubomir Rintel <lkundrak@v3.sk> - 2017-04-19 18:20 +0200
          Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:50 +0200
            Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Mark Brown <broonie@kernel.org> - 2017-04-20 21:50 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-20 22:30 +0200
              Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building  designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-20 22:30 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm as a module Takashi Iwai <tiwai@suse.de> - 2017-04-21 12:40 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Mark Brown <broonie@kernel.org> - 2017-04-21 12:50 +0200
                Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm  as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-21 12:40 +0200
        Re: [PATCH] ASoC: dwc: disallow building designware_pcm as a module Jose Abreu <Jose.Abreu@synopsys.com> - 2017-04-19 18:20 +0200

csiph-web