Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589736

[PATCH v2 0/3] perf annotate: Introduce the new source code view

Show all headers | View raw

Hi,

Currently perf-annotate have several problems.

  - Wrong line numbers on perf-annotate (both stdio and TUI)
  - Wrong sum of overhead(percent) matching source lines
  - It's so confusing that the output is mixed with
    both source code and assembly code. (related to depending on 'objdump -S')

So fix them regarding wrong line numbers
and Introduce new source_code collecting actual code,
not depending on 'objdump -S'.

I'd appreciate some feedback.

Thanks,
Taeung

v2:
- contains the new source code view (Namhyung)

Taeung Song (3):
  perf annotate: Get correct line numbers matched with addr
  perf annotate: Introduce the new source code view
  perf annotate: Support the new source code view for TUI

 tools/perf/builtin-annotate.c     |   2 +-
 tools/perf/ui/browsers/annotate.c | 175 ++++++++++++++++-------
 tools/perf/util/annotate.c        | 292 ++++++++++++++++++++++++++++++++++----
 tools/perf/util/annotate.h        |  28 ++++
 4 files changed, 419 insertions(+), 78 deletions(-)

-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
  [PATCH v2 3/3] perf annotate: Support the new source code view for TUI Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
  [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
    Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Namhyung Kim <namhyung@kernel.org> - 2017-03-01 14:30 +0100
      Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Taeung Song <treeze.taeung@gmail.com> - 2017-03-02 07:10 +0100
        Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Namhyung Kim <namhyung@kernel.org> - 2017-03-03 03:50 +0100
          Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Taeung Song <treeze.taeung@gmail.com> - 2017-03-03 04:40 +0100
  [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
    Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:00 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:30 +0100
        Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:40 +0100
          Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 16:10 +0100
            Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 16:40 +0100
              Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-03-01 17:00 +0100
              Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-03 07:30 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:50 +0100

csiph-web