Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view
Date	2017-03-01 15:40 +0100
Message-ID	<tgdA6-4nt-3@gated-at.bofh.it> (permalink)
References	<tfWfT-NX-3@gated-at.bofh.it> <tfWfT-NX-17@gated-at.bofh.it> <tgcXn-3Po-1@gated-at.bofh.it> <tgdqq-4gi-13@gated-at.bofh.it> <tgdqq-4gi-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 01, 2017 at 11:21:33PM +0900, Namhyung Kim wrote:

> > What's the point of source-only? You can't even see what it is that is
> > expensive.
> 
> ???

From a line like:

		a = b ? ptr->c : 0;

How do you tell what it is that causes the problem, the branch miss or
the pointer deref?

Typically looking at the asm this is fairly clear; even without
recording with more specific events.

> This is to show source code + overhead (for each line).  People can
> see which line of their source is expensive.  I think it's way more
> intuitive for most developers..

And how pray are you going to write better code if you have no clue what
the problem is?

I'm really wondering how you can even think about performance if you're
scared of asm.

Thread

[PATCH v2 0/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
  [PATCH v2 3/3] perf annotate: Support the new source code view for TUI Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
  [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
    Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Namhyung Kim <namhyung@kernel.org> - 2017-03-01 14:30 +0100
      Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Taeung Song <treeze.taeung@gmail.com> - 2017-03-02 07:10 +0100
        Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Namhyung Kim <namhyung@kernel.org> - 2017-03-03 03:50 +0100
          Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Taeung Song <treeze.taeung@gmail.com> - 2017-03-03 04:40 +0100
  [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
    Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:00 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:30 +0100
        Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:40 +0100
          Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 16:10 +0100
            Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 16:40 +0100
              Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-03-01 17:00 +0100
              Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-03 07:30 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:50 +0100

csiph-web