Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1589735

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations.

Show all headers | View raw

Use a single fmt string with appropriate verbs as conversion specifiers,
followed by the original string literals and the integer argument
instead of using a backslash to escape a new line embedded inbetween
quoted string literals passed as fmt arguments to dev_err() invoked in
drivers/staging/fbtft/fb_ssd1331.c.

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
 drivers/staging/fbtft/fb_ssd1331.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index 26f24e3..6d03041 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
 
 	for (i = 0; i < 63; i++) {
 		if (i > 0 && curves[i] < 2) {
-			dev_err(par->info->device,
-				"Illegal value in Grayscale Lookup Table at index %d. " \
-				"Must be greater than 1\n", i);
+			dev_err(par->info->device, "%s %d. %s\n",
+				"Illegal value in Grayscale Lookup Table at index",
+				i,
+				"Must be greater than 1");
 			return -EINVAL;
 		}
 		acc += curves[i];
 		tmp[i] = acc;
 		if (acc > 180) {
-			dev_err(par->info->device,
-				"Illegal value(s) in Grayscale Lookup Table. " \
-				"At index=%d, the accumulated value has exceeded 180\n", i);
+			dev_err(par->info->device, "%s%d, %s\n",
+				"Illegal value(s) in Grayscale Lookup Table. At index=",
+				i,
+				"the accumulated value has exceeded 180");
 			return -EINVAL;
 		}
 	}
-- 
2.10.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-02-28 21:10 +0100
  Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about  unnecessary line continuations. Joe Perches <joe@perches.com> - 2017-02-28 21:40 +0100
    Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about  unnecessary line continuations. Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-02-28 22:40 +0100
  Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about  unnecessary line continuations. Greg KH <gregkh@linuxfoundation.org> - 2017-03-01 11:00 +0100
    [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-03-04 10:10 +0100

csiph-web