Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view
Date	2017-03-01 15:30 +0100
Message-ID	<tgdqq-4gi-11@gated-at.bofh.it> (permalink)
References	<tfWfT-NX-3@gated-at.bofh.it> <tfWfT-NX-17@gated-at.bofh.it> <tgcXn-3Po-1@gated-at.bofh.it> <tgdqq-4gi-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Peter,

On Wed, Mar 01, 2017 at 03:08:33PM +0100, Peter Zijlstra wrote:
> On Wed, Mar 01, 2017 at 10:58:05PM +0900, Namhyung Kim wrote:
> > On Wed, Mar 01, 2017 at 04:59:52AM +0900, Taeung Song wrote:
> > > The current source code view using 'objdump -S'
> > > has several limitations regarding line numbers of each soure
> > > code line and confusing mixed soure code & diassembly view.
> > > 
> > > So not use the '-S' option any more and
> > > add the new reable source code view with
> > > correct line numbers and source code per each symbol(function)
> > > using new struct source_code.
> > 
> > I like this "source-only" annotation, but some people still might want
> > to see the "mixed" annotation.  So I think you need to keep it and
> > provide another option for the source-only mode.  And then we can
> > change the default later.
> 
> What's the point of source-only? You can't even see what it is that is
> expensive.

???

This is to show source code + overhead (for each line).  People can
see which line of their source is expensive.  I think it's way more
intuitive for most developers..

Thanks,
Namhyung

Thread

[PATCH v2 0/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
  [PATCH v2 3/3] perf annotate: Support the new source code view for TUI Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
  [PATCH v2 1/3] perf annotate: Get correct line numbers matched with addr Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
    Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Namhyung Kim <namhyung@kernel.org> - 2017-03-01 14:30 +0100
      Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Taeung Song <treeze.taeung@gmail.com> - 2017-03-02 07:10 +0100
        Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Namhyung Kim <namhyung@kernel.org> - 2017-03-03 03:50 +0100
          Re: [PATCH v2 1/3] perf annotate: Get correct line numbers matched  with addr Taeung Song <treeze.taeung@gmail.com> - 2017-03-03 04:40 +0100
  [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-02-28 21:10 +0100
    Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:00 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:30 +0100
        Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:40 +0100
          Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 16:10 +0100
            Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 16:40 +0100
              Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-03-01 17:00 +0100
              Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-03 07:30 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:50 +0100

csiph-web