Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view

From	Namhyung Kim <namhyung@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view
Date	2017-03-03 07:30 +0100
Message-ID	<tgOT0-5tc-7@gated-at.bofh.it> (permalink)
References	(3 earlier) <tgdqq-4gi-13@gated-at.bofh.it> <tgdqq-4gi-11@gated-at.bofh.it> <tgdA6-4nt-3@gated-at.bofh.it> <tge38-4N8-9@gated-at.bofh.it> <tgew9-4ZE-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Peter,

On Wed, Mar 01, 2017 at 04:07:46PM +0100, Peter Zijlstra wrote:
> On Wed, Mar 01, 2017 at 11:56:39PM +0900, Namhyung Kim wrote:
> 
> > It's a kind of user experience issue.  We provide the asm-only and
> > asm+source annotation, and I think it'd be nice to add source-only
> > option.  And I remember that it was requested some time ago..
> 
> Thing is, an optimizing compiler -- that same beast that ensures your
> objdump -S output is such a garbled mess -- can generate code that
> becomes very hard to relate to the original source code.

I understand that.  Maybe it's not 100% accurate, but it still has
valuable information.  And I think the source-only view can give more
readable outputs using the info.  Also I guess many developers already
aware of the effect of optimizing compilers.

> 
> I'm really sceptical the source line only view is very useful; maybe if
> you build with -O0, but then, if you do that you're not bothered with
> performance.

Even with an optimizing compiler, it can be helpful to overview which
parts of the code are bottlenecks IMHO.  After that, one can see the
asm to identify the problem deeply, if needed.

Thanks,
Namhyung

Thread

Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:00 +0100
  Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 15:30 +0100
    Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:40 +0100
      Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-01 16:10 +0100
        Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 16:40 +0100
          Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Taeung Song <treeze.taeung@gmail.com> - 2017-03-01 17:00 +0100
          Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Namhyung Kim <namhyung@kernel.org> - 2017-03-03 07:30 +0100
  Re: [PATCH v2 2/3] perf annotate: Introduce the new source code view Peter Zijlstra <peterz@infradead.org> - 2017-03-01 15:50 +0100

csiph-web