Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1635763

Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver

Path csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From Icenowy Zheng <icenowy@aosc.io>
Newsgroups linux.kernel
Subject Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver
Date Thu, 04 May 2017 16:20:01 +0200
Message-ID <tDpLP-4yP-5@gated-at.bofh.it> (permalink)
References <tDpsu-4bq-9@gated-at.bofh.it> <tDpsu-4bq-23@gated-at.bofh.it> <tDpCa-4uB-29@gated-at.bofh.it>
X-Original-To Maxime Ripard <maxime.ripard@free-electrons.com>
MIME-Version 1.0
Content-Type text/plain; charset=utf-8
Content-Transfer-Encoding 8BIT
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 17
Organization linux.* mail to news gateway
X-Original-Cc Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Linus Walleij <linus.walleij@linaro.org>, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-sunxi@googlegroups.com
X-Original-Date Thu, 04 May 2017 22:07:47 +0800
X-Original-Message-ID <318E9984-9F5A-41C3-A3E0-52D5ECA05212@aosc.io>
X-Original-References <20170504135006.16483-1-icenowy@aosc.io> <20170504135006.16483-3-icenowy@aosc.io> <20170504140431.zhpcxvphxnxj7ipq@lukather>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1635763

Show key headers only | View raw



于 2017年5月4日 GMT+08:00 下午10:04:31, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
>On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote:
>> Allwinner A10, A20 and R40 SoCs have similar GPIO layout.
>> 
>> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
>> into A10 driver, and add R40 support into it.
>
>While your commit log is good, the commit title is misleading since
>you're not adding it to the A10 driver. You just adding SoC IDs
>definitions

Is "pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs" OK?

>
>Maxime

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:00 +0200
  Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and  R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:10 +0200
    Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
      Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and  R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 17:00 +0200

csiph-web