Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver
Date	2017-05-04 17:00 +0200
Message-ID	<tDqoy-4PF-19@gated-at.bofh.it> (permalink)
References	<tDpsu-4bq-9@gated-at.bofh.it> <tDpsu-4bq-23@gated-at.bofh.it> <tDpCa-4uB-29@gated-at.bofh.it> <tDpLP-4yP-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, May 04, 2017 at 10:07:47PM +0800, Icenowy Zheng wrote:
> 
> 
> 于 2017年5月4日 GMT+08:00 下午10:04:31, Maxime Ripard <maxime.ripard@free-electrons.com> 写到:
> >On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote:
> >> Allwinner A10, A20 and R40 SoCs have similar GPIO layout.
> >> 
> >> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
> >> into A10 driver, and add R40 support into it.
> >
> >While your commit log is good, the commit title is misleading since
> >you're not adding it to the A10 driver. You just adding SoC IDs
> >definitions
> 
> Is "pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs" OK?

Yep, it is, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:00 +0200
  Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and  R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:10 +0200
    Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
      Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and  R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 17:00 +0200

csiph-web