Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1635764

Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static

Show all headers | View raw

On Thu,  4 May 2017 13:11:00 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> nand_ooblayout_lp_hamming_ops can be made static as it does not need to be
> in global scope.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Brian, feel free to apply this patch directly if you want, otherwise,
I'll queue it for 4.13.

> ---
>  drivers/mtd/nand/nand_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
> index d474378ed810..d3a735012b81 100644
> --- a/drivers/mtd/nand/nand_base.c
> +++ b/drivers/mtd/nand/nand_base.c
> @@ -202,7 +202,7 @@ static int nand_ooblayout_free_lp_hamming(struct mtd_info *mtd, int section,
>  	return 0;
>  }
>  
> -const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
> +static const struct mtd_ooblayout_ops nand_ooblayout_lp_hamming_ops = {
>  	.ecc = nand_ooblayout_ecc_lp_hamming,
>  	.free = nand_ooblayout_free_lp_hamming,
>  };

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Colin King <colin.king@canonical.com> - 2017-05-04 14:20 +0200
  Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-05-04 16:20 +0200
    Re: [PATCH] mtd: nand: make nand_ooblayout_lp_hamming_ops static Brian Norris <computersforpeace@gmail.com> - 2017-05-11 20:40 +0200

csiph-web