Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1635757

Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver

From Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver
Date 2017-05-04 16:10 +0200
Message-ID <tDpCa-4uB-29@gated-at.bofh.it> (permalink)
References <tDpsu-4bq-9@gated-at.bofh.it> <tDpsu-4bq-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote:
> Allwinner A10, A20 and R40 SoCs have similar GPIO layout.
> 
> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
> into A10 driver, and add R40 support into it.

While your commit log is good, the commit title is misleading since
you're not adding it to the A10 driver. You just adding SoC IDs
definitions

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:00 +0200
  Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and  R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:10 +0200
    Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
      Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and  R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 17:00 +0200

csiph-web