Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1635749 > unrolled thread
| Started by | Icenowy Zheng <icenowy@aosc.io> |
|---|---|
| First post | 2017-05-04 16:00 +0200 |
| Last post | 2017-05-04 17:00 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:00 +0200
Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 16:10 +0200
Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Icenowy Zheng <icenowy@aosc.io> - 2017-05-04 16:20 +0200
Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-05-04 17:00 +0200
| From | Icenowy Zheng <icenowy@aosc.io> |
|---|---|
| Date | 2017-05-04 16:00 +0200 |
| Subject | [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver |
| Message-ID | <tDpsu-4bq-23@gated-at.bofh.it> |
Allwinner A10, A20 and R40 SoCs have similar GPIO layout.
Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support
into A10 driver, and add R40 support into it.
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
drivers/pinctrl/sunxi/pinctrl-sunxi.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.h b/drivers/pinctrl/sunxi/pinctrl-sunxi.h
index a9d315a1256c..1bfc0d8a55df 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.h
+++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.h
@@ -87,6 +87,9 @@
#define PINCTRL_SUN5I_GR8 BIT(3)
#define PINCTRL_SUN6I_A31 BIT(4)
#define PINCTRL_SUN6I_A31S BIT(5)
+#define PINCTRL_SUN4I_A10 BIT(6)
+#define PINCTRL_SUN7I_A20 BIT(7)
+#define PINCTRL_SUN8I_R40 BIT(8)
struct sunxi_desc_function {
unsigned long variant;
--
2.12.2
[toc] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-05-04 16:10 +0200 |
| Subject | Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver |
| Message-ID | <tDpCa-4uB-29@gated-at.bofh.it> |
| In reply to | #1635749 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote: > Allwinner A10, A20 and R40 SoCs have similar GPIO layout. > > Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support > into A10 driver, and add R40 support into it. While your commit log is good, the commit title is misleading since you're not adding it to the A10 driver. You just adding SoC IDs definitions Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [next] | [standalone]
| From | Icenowy Zheng <icenowy@aosc.io> |
|---|---|
| Date | 2017-05-04 16:20 +0200 |
| Message-ID | <tDpLP-4yP-5@gated-at.bofh.it> |
| In reply to | #1635757 |
于 2017年5月4日 GMT+08:00 下午10:04:31, Maxime Ripard <maxime.ripard@free-electrons.com> 写到: >On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote: >> Allwinner A10, A20 and R40 SoCs have similar GPIO layout. >> >> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support >> into A10 driver, and add R40 support into it. > >While your commit log is good, the commit title is misleading since >you're not adding it to the A10 driver. You just adding SoC IDs >definitions Is "pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs" OK? > >Maxime
[toc] | [prev] | [next] | [standalone]
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Date | 2017-05-04 17:00 +0200 |
| Subject | Re: [PATCH v2 02/10] pinctrl: sunxi: add definitions for add A20 and R40 support to A10 driver |
| Message-ID | <tDqoy-4PF-19@gated-at.bofh.it> |
| In reply to | #1635763 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, May 04, 2017 at 10:07:47PM +0800, Icenowy Zheng wrote: > > > 于 2017年5月4日 GMT+08:00 下午10:04:31, Maxime Ripard <maxime.ripard@free-electrons.com> 写到: > >On Thu, May 04, 2017 at 09:49:58PM +0800, Icenowy Zheng wrote: > >> Allwinner A10, A20 and R40 SoCs have similar GPIO layout. > >> > >> Add SoC definitions in pinctrl-sunxi.h, in order to merge A20 support > >> into A10 driver, and add R40 support into it. > > > >While your commit log is good, the commit title is misleading since > >you're not adding it to the A10 driver. You just adding SoC IDs > >definitions > > Is "pinctrl: sunxi: Add SoC ID definitions for A10, A20 and R40 SoCs" OK? Yep, it is, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web