Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1551039

Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy

Show all headers | View raw

On Wed, Jan 04, 2017 at 09:34:32PM +0900, Jaehoon Chung wrote:
> This patch supports to use Generic Phy framework for Exynos PCIe phy.
> When Exynos that supported the pcie want to use the PCIe,
> it needs to control the phy resgister.
> But it should be more complex to control in their own PCIe device drivers.
> 
> Currently, there is an exynos5440 case to support the pcie.
> So this driver is based on Exynos5440 PCIe.
> In future, will support the Other exynos SoCs likes exynos5433, exynos7.

I have troubles understanding this. Please, work on the commit message.

For the code itself:
Acked-by: Krzysztof Kozlowski <krzk@kernel.org>
... but commit message is really important to understand why/what was
done.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 0/5] PCI: exynos: use the PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
  [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
    Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node  for pcie Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-04 19:10 +0100
      Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for pcie "Jingoo Han" <jingoohan1@gmail.com> - 2017-01-04 19:10 +0100
      Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for  pcie Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-05 03:30 +0100
    Re: [PATCH V2 5/5] ARM: dts: exynos5440: support the phy-pcie node for  pcie "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 10:10 +0100
  [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
    Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-04 19:00 +0100
      Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-05 03:30 +0100
    Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe phy "Jingoo Han" <jingoohan1@gmail.com> - 2017-01-04 21:30 +0100
    Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 07:20 +0100
    Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Alim Akhtar <alim.akhtar@samsung.com> - 2017-01-09 14:40 +0100
    Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-01-10 07:10 +0100
      Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-10 07:20 +0100
    Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Kishon Vijay Abraham I <kishon@ti.com> - 2017-01-16 09:40 +0100
      Re: [PATCH V2 2/5] phy: phy-exynos-pcie: Add support for Exynos PCIe  phy Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-16 12:10 +0100
  [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy  binding Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
    Re: [PATCH V2 1/5] Documetation: samsung-phy: add the  exynos-pcie-phy binding Rob Herring <robh@kernel.org> - 2017-01-04 16:20 +0100
    Re: [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy  binding Alim Akhtar <alim.akhtar@samsung.com> - 2017-01-05 05:30 +0100
      Re: [PATCH V2 1/5] Documetation: samsung-phy: add the exynos-pcie-phy  binding "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 07:10 +0100
  [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-04 13:40 +0100
    Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic  framework Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-04 19:00 +0100
      Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Jaehoon Chung <jh80.chung@samsung.com> - 2017-01-05 03:40 +0100
    Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework "Jingoo Han" <jingoohan1@gmail.com> - 2017-01-04 21:00 +0100
    Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework "pankaj.dubey" <pankaj.dubey@samsung.com> - 2017-01-05 10:10 +0100
    Re: [PATCH V2 4/5] PCI: exynos: support the using PHY generic framework Alim Akhtar <alim.akhtar@samsung.com> - 2017-01-09 14:50 +0100
  Re: [PATCH V2 0/5] PCI: exynos: use the PHY generic framework Bjorn Helgaas <helgaas@kernel.org> - 2017-01-12 22:10 +0100

csiph-web