Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537624

Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

Show all headers | View raw

On Tue, Dec 06, 2016 at 08:09:31PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> Add some helpers for the crc checks for the slave configuration table.
> This works 4-bits-at-a-time, using a simple table approach.
> 
> We will need this in the FSI core code, as well as any master
> implementations that need to calculate CRCs in software.
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c   | 21 +++++++++++++++++++++
>  drivers/fsi/fsi-master.h | 21 +++++++++++++++++++++
>  2 files changed, 42 insertions(+)

Why not just create lib/crc4.c with these functions, like the other crc
functions in the kernel?  Don't bury these in some random driver
subsystem please.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:10 +0100
  [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
  [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
  [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
    Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:40 +0100
  [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
    Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:20 +0100
      Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Jeremy Kerr <jk@ozlabs.org> - 2016-12-08 00:40 +0100
        Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 20:50 +0100
  Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:10 +0100
    Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 23:50 +0100

csiph-web