Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1537629
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions |
| Date | 2016-12-07 10:40 +0100 |
| Message-ID | <sLGRI-6H9-7@gated-at.bofh.it> (permalink) |
| References | <sLzQe-1LR-5@gated-at.bofh.it> <sLzZT-1SH-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Dec 06, 2016 at 08:09:33PM -0600, Chris Bostic wrote:
> diff --git a/include/linux/fsi.h b/include/linux/fsi.h
> index efa55ba..66bce48 100644
> --- a/include/linux/fsi.h
> +++ b/include/linux/fsi.h
> @@ -27,6 +27,12 @@ struct fsi_device {
> uint32_t size;
> };
>
> +extern int fsi_device_read(struct fsi_device *dev, uint32_t addr,
> + void *val, size_t size);
> +extern int fsi_device_write(struct fsi_device *dev, uint32_t addr,
> + const void *val, size_t size);
> +extern int fsi_device_peek(struct fsi_device *dev, void *val);
> +
> struct fsi_device_id {
> u8 engine_type;
> u8 version;
> @@ -40,7 +46,6 @@ struct fsi_device_id {
> #define FSI_DEVICE_VERSIONED(t, v) \
> .engine_type = (t), .version = (v),
>
> -
> struct fsi_driver {
> struct device_driver drv;
> const struct fsi_device_id *id_table;
Strange whitespace change here :)
Not a real problem, I like the fact that you have broken this down into
very logical pieces making it much easier to review, thanks so much for
doing this.
greg k-h
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:10 +0100
[PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
[PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
[PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:40 +0100
[PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:20 +0100
Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Jeremy Kerr <jk@ozlabs.org> - 2016-12-08 00:40 +0100
Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 20:50 +0100
Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:10 +0100
Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 23:50 +0100
csiph-web