Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1538185

Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers

From Jeremy Kerr <jk@ozlabs.org>
Newsgroups linux.kernel
Subject Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers
Date 2016-12-08 00:40 +0100
Message-ID <sLTYC-6Me-5@gated-at.bofh.it> (permalink)
References <sLzQe-1LR-5@gated-at.bofh.it> <sLzZU-1SH-17@gated-at.bofh.it> <sLGym-6AF-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Greg,

> Why not just create lib/crc4.c with these functions, like the other crc
> functions in the kernel?

Two (bad) reasons:

 - The crc4 implementation here is pretty specific to the FSI
   usage (only supporting 4-bit-sized chunks), to keep the math & lookup
   table simple

 - I'm lazy

So yes, we should spend the effort now to make this generic enough for
a lib/crc4.c. Would we want to support different values for the
polynomial?

Chris: do you want me to to that, or will you?

Cheers,


Jeremy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:10 +0100
  [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
  [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
  [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
    Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:40 +0100
  [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
    Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:20 +0100
      Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Jeremy Kerr <jk@ozlabs.org> - 2016-12-08 00:40 +0100
        Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 20:50 +0100
  Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:10 +0100
    Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 23:50 +0100

csiph-web