Re: [PATCHv13 2/3] usb: USB Type-C connector class

From	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv13 2/3] usb: USB Type-C connector class
Date	2016-12-07 10:20 +0100
Message-ID	<sLGym-6AF-25@gated-at.bofh.it> (permalink)
References	<sH1k5-2AQ-3@gated-at.bofh.it> <sH1k5-2AQ-1@gated-at.bofh.it> <sITs5-2o0-11@gated-at.bofh.it> <sJ9nb-4fE-9@gated-at.bofh.it> <sK0rv-7f6-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 02, 2016 at 10:04:39AM -0800, Guenter Roeck wrote:
> At least for my part I very much concentrated on making sure that
> the user space ABI as well as the port driver API are sane and usable.
> 
> The driver interface is not my area of expertise. As such, my testing
> and understanding of that part was limited to "it appears to work,
> it must be ok". I very much relied on you to get this part right.
> 
> That makes me feel really bad. It isn't fun to have my "Reviewed-by"
> on a patch that gets (and apparently deserves) a WTF from a senior
> kernel maintainer. This hurts both your and my reputation, and obviously
> will make me quite hesitant to add a "Reviewed-by:" to the next version
> of the series.

I don't usually get very upset about stronger comments, even if they
are coming from senior kernel maintainer like Greg, but your concern
does make me feel like crap. I'm sorry Guenter.

Please just note that nobody else has considered the approach as a
problem or noticed it before Greg any more then you, and this code has
by now been review by many, including some people who I consider senior
kernel developers and maintainers, both internally inside Intel and
also publicly on these lists.

> No more shortcuts, please.

No.

Br,

-- 
heikki

Thread

Re: [PATCHv13 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-11-29 17:30 +0100
  Re: [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-11-30 10:30 +0100
    Re: [PATCHv13 2/3] usb: USB Type-C connector class Guenter Roeck <linux@roeck-us.net> - 2016-12-02 19:10 +0100
      Re: [PATCHv13 2/3] usb: USB Type-C connector class Greg KH <gregkh@linuxfoundation.org> - 2016-12-02 19:30 +0100
      Re: [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-12-07 10:20 +0100
      Re: [PATCHv13 2/3] usb: USB Type-C connector class Oliver Neukum <oneukum@suse.com> - 2016-12-07 11:00 +0100
        Re: [PATCHv13 2/3] usb: USB Type-C connector class Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-12-07 14:10 +0100

csiph-web