Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1537620

Re: [PATCH 04/16] drivers/fsi: Add fsi master definition

Show all headers | View raw

On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote:
> From: Jeremy Kerr <jk@ozlabs.org>
> 
> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
> ---
>  drivers/fsi/fsi-core.c   | 20 ++++++++++++++++++++
>  drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 57 insertions(+)
>  create mode 100644 drivers/fsi/fsi-master.h
> 
> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
> index 3d55bd5..ce9428d 100644
> --- a/drivers/fsi/fsi-core.c
> +++ b/drivers/fsi/fsi-core.c
> @@ -17,6 +17,26 @@
>  #include <linux/fsi.h>
>  #include <linux/module.h>
>  
> +#include "fsi-master.h"
> +
> +static atomic_t master_idx = ATOMIC_INIT(-1);

You don't really want/need an atomic variable, please use the simple ida
interface instead.

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:10 +0100
  [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
  [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
  [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
    Re: [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:40 +0100
  [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic <christopher.lee.bostic@gmail.com> - 2016-12-07 03:20 +0100
    Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:20 +0100
      Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Jeremy Kerr <jk@ozlabs.org> - 2016-12-08 00:40 +0100
        Re: [PATCH 08/16] drivers/fsi: Add crc4 helpers Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 20:50 +0100
  Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH <gregkh@linuxfoundation.org> - 2016-12-07 10:10 +0100
    Re: [PATCH 04/16] drivers/fsi: Add fsi master definition Christopher Bostic <christopher.lee.bostic@gmail.com> - 2016-12-08 23:50 +0100

csiph-web