Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1352554

Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that can be added to dynamically [ver #2]

Show all headers | View raw

On Fri, 2016-03-04 at 15:01 +0000, David Howells wrote:
> Add a secondary system keyring that can be added to by root whilst the
> system is running - provided the key being added is vouched for by a key
> built into the kernel or already added to the secondary keyring.
> 
> Rename .system_keyring to .builtin_trusted_keys to distinguish it more
> obviously from the new keyring (called .secondary_trusted_keys).

Renaming of the system_trusted_keyring to builtin_trusted_keys is fine,
but we're left with a lot of references to "system_trusted" (eg.
restrict_link_to_system_trusted, depends on SYSTEM_TRUSTED_KEYRING,  the
subsequent patch description and Kconfig use "system trusted keyrings",
etc).   Without changing these references, I'm not convinced this is an
improvement. 

Mimi

> The new keyring needs to be enabled with CONFIG_SECONDARY_TRUSTED_KEYRING.
> 
> If the secondary keyring is enabled, a link is created from that to
> .builtin_trusted_keys so that the the latter will automatically be searched
> too if the secondary keyring is searched.
> 
> Signed-off-by: David Howells <dhowells@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 00/12] KEYS: Restrict additions to 'trusted' keyrings  [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 04/12] KEYS: Move x509_request_asymmetric_key() to  asymmetric_type.c [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead  of .ima_mok [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
    Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 03:30 +0100
      Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #2] David Howells <dhowells@redhat.com> - 2016-03-08 14:10 +0100
        Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Petko Manolov <petkan@mip-labs.com> - 2016-03-08 15:20 +0100
          Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 15:40 +0100
          Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #2] David Howells <dhowells@redhat.com> - 2016-03-08 15:50 +0100
            Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Petko Manolov <petkan@mip-labs.com> - 2016-03-08 16:50 +0100
          Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings instead of .ima_mok [ver #2] David Howells <dhowells@redhat.com> - 2016-03-08 17:10 +0100
            Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Petko Manolov <petkan@mip-labs.com> - 2016-03-08 17:40 +0100
              Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 23:10 +0100
        Re: [RFC PATCH 12/12] IMA: Use the the system trusted keyrings  instead of .ima_mok [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 15:20 +0100
  [RFC PATCH 07/12] X.509: Move the trust validation code out to its  own file [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 11/12] certs: Add a secondary system keyring that can be  added to dynamically [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
    Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that  can be added to dynamically [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 03:10 +0100
      Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that can be added to dynamically [ver #2] David Howells <dhowells@redhat.com> - 2016-03-08 14:20 +0100
        Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that can  be added to dynamically [ver #2] Petko Manolov <petkan@mip-labs.com> - 2016-03-08 15:20 +0100
        Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that  can be added to dynamically [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 15:40 +0100
          Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that can be added to dynamically [ver #2] David Howells <dhowells@redhat.com> - 2016-03-08 15:50 +0100
            Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that  can be added to dynamically [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 16:10 +0100
              Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that can be added to dynamically [ver #2] David Howells <dhowells@redhat.com> - 2016-03-08 16:40 +0100
                Re: [RFC PATCH 11/12] certs: Add a secondary system keyring that  can be added to dynamically [ver #2] Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-03-08 17:20 +0100
  [RFC PATCH 05/12] KEYS: Generalise x509_request_asymmetric_key()  [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 09/12] KEYS: Move the point of trust determination to  __key_link() [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 02/12] PKCS#7: Make trust determination dependent on  contents of trust keyring [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 06/12] X.509: Use verify_signature() if we have a struct  key * to use [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100
  [RFC PATCH 10/12] KEYS: Remove KEY_FLAG_TRUSTED and  KEY_ALLOC_TRUSTED [ver #2] David Howells <dhowells@redhat.com> - 2016-03-04 16:10 +0100

csiph-web