Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1264844
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() |
| Date | 2015-11-07 15:20 +0100 |
| Message-ID | <qscvx-3nb-19@gated-at.bofh.it> (permalink) |
| References | <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrJtv-1pc-3@gated-at.bofh.it> <qs3se-5TG-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 7 Nov 2015 15:10:29 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 08:20 +0100
Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 05:40 +0100
[PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 15:20 +0100
Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() David Miller <davem@davemloft.net> - 2015-11-07 16:00 +0100
[PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 16:40 +0100
Re: [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 19:20 +0100
csiph-web