Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put()
Date	2015-11-07 16:00 +0100
Message-ID	<qsd8e-3Cy-1@gated-at.bofh.it> (permalink)
References	<qrJtv-1pc-3@gated-at.bofh.it> <qs3se-5TG-7@gated-at.bofh.it> <qscvx-3nb-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 7 Nov 2015 15:15:24 +0100

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 7 Nov 2015 15:10:29 +0100
> 
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

As I requested of you last night, please phrase the subsystem
prefix of your Subject lines more correctly.

Just use the driver's name, in lower case, as one single word,
which in this case would be "dwc_eth_qos: ".

I'm telling you exactly what to use in the Subject line, there
is no ambiguity or confusion on what you need to do for me to
accept this patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] DWC Ethernet QoS: Delete an unnecessary check before the  function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 08:20 +0100
  Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before  the function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 05:40 +0100
    [PATCH] ethernet-synopsys: Delete an unnecessary check before  of_node_put() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 15:20 +0100
      Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before  of_node_put() David Miller <davem@davemloft.net> - 2015-11-07 16:00 +0100
    [PATCH] dwc_eth_qos: Delete an unnecessary check before the function  call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 16:40 +0100
      Re: [PATCH] dwc_eth_qos: Delete an unnecessary check before the  function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 19:20 +0100

csiph-web