Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put"

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put"
Date	2015-11-07 05:40 +0100
Message-ID	<qs3se-5TG-7@gated-at.bofh.it> (permalink)
References	<mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qrJtv-1pc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: SF Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 6 Nov 2015 08:15:30 +0100

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 6 Nov 2015 08:00:22 +0100
> 
> The of_node_put() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Please resubmit this with a more appropriate Subject line.

The subsystem prefix should be all lower-case and typically
indicate the most specific subsystem or area being changed.

In this case it's a driver, therefore simply use the driver
name "dwc_eth_qos: ".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] DWC Ethernet QoS: Delete an unnecessary check before the  function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 08:20 +0100
  Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before  the function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 05:40 +0100
    [PATCH] ethernet-synopsys: Delete an unnecessary check before  of_node_put() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 15:20 +0100
      Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before  of_node_put() David Miller <davem@davemloft.net> - 2015-11-07 16:00 +0100
    [PATCH] dwc_eth_qos: Delete an unnecessary check before the function  call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 16:40 +0100
      Re: [PATCH] dwc_eth_qos: Delete an unnecessary check before the  function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 19:20 +0100

csiph-web