Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1263794 > unrolled thread
| Started by | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| First post | 2015-11-06 08:20 +0100 |
| Last post | 2015-11-07 19:20 +0100 |
| Articles | 6 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-06 08:20 +0100
Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 05:40 +0100
[PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 15:20 +0100
Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() David Miller <davem@davemloft.net> - 2015-11-07 16:00 +0100
[PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-07 16:40 +0100
Re: [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" David Miller <davem@davemloft.net> - 2015-11-07 19:20 +0100
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2015-11-06 08:20 +0100 |
| Subject | [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" |
| Message-ID | <qrJtv-1pc-3@gated-at.bofh.it> |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 6 Nov 2015 08:00:22 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-11-07 05:40 +0100 |
| Subject | Re: [PATCH] DWC Ethernet QoS: Delete an unnecessary check before the function call "of_node_put" |
| Message-ID | <qs3se-5TG-7@gated-at.bofh.it> |
| In reply to | #1263794 |
From: SF Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 6 Nov 2015 08:15:30 +0100 > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 6 Nov 2015 08:00:22 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Please resubmit this with a more appropriate Subject line. The subsystem prefix should be all lower-case and typically indicate the most specific subsystem or area being changed. In this case it's a driver, therefore simply use the driver name "dwc_eth_qos: ". -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2015-11-07 15:20 +0100 |
| Subject | [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() |
| Message-ID | <qscvx-3nb-19@gated-at.bofh.it> |
| In reply to | #1264731 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 7 Nov 2015 15:10:29 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-11-07 16:00 +0100 |
| Subject | Re: [PATCH] ethernet-synopsys: Delete an unnecessary check before of_node_put() |
| Message-ID | <qsd8e-3Cy-1@gated-at.bofh.it> |
| In reply to | #1264844 |
From: SF Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 7 Nov 2015 15:15:24 +0100 > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 7 Nov 2015 15:10:29 +0100 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> As I requested of you last night, please phrase the subsystem prefix of your Subject lines more correctly. Just use the driver's name, in lower case, as one single word, which in this case would be "dwc_eth_qos: ". I'm telling you exactly what to use in the Subject line, there is no ambiguity or confusion on what you need to do for me to accept this patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | SF Markus Elfring <elfring@users.sourceforge.net> |
|---|---|
| Date | 2015-11-07 16:40 +0100 |
| Subject | [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" |
| Message-ID | <qsdKW-45U-9@gated-at.bofh.it> |
| In reply to | #1264731 |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 7 Nov 2015 16:30:34 +0100 The of_node_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/synopsys/dwc_eth_qos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/synopsys/dwc_eth_qos.c b/drivers/net/ethernet/synopsys/dwc_eth_qos.c index 85b3326..9066d7a 100644 --- a/drivers/net/ethernet/synopsys/dwc_eth_qos.c +++ b/drivers/net/ethernet/synopsys/dwc_eth_qos.c @@ -2970,8 +2970,7 @@ err_out_unregister_netdev: err_out_clk_dis_aper: clk_disable_unprepare(lp->apb_pclk); err_out_free_netdev: - if (lp->phy_node) - of_node_put(lp->phy_node); + of_node_put(lp->phy_node); free_netdev(ndev); platform_set_drvdata(pdev, NULL); return ret; -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2015-11-07 19:20 +0100 |
| Subject | Re: [PATCH] dwc_eth_qos: Delete an unnecessary check before the function call "of_node_put" |
| Message-ID | <qsgfM-5MQ-5@gated-at.bofh.it> |
| In reply to | #1264864 |
From: SF Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 7 Nov 2015 16:34:48 +0100 > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sat, 7 Nov 2015 16:30:34 +0100 > > The of_node_put() function tests whether its argument is NULL > and then returns immediately. > Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web