Re: [PATCH] scsi: mvsas: fix indenting on return error code

Path	csiph.com!au2pb.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: mvsas: fix indenting on return error code
Date	Wed, 06 Jan 2016 21:30:02 +0100
Message-ID	<qO2Su-5Zm-17@gated-at.bofh.it> (permalink)
References	<qNyro-2dj-9@gated-at.bofh.it>
X-Original-To	Colin King <colin.king@canonical.com>
Organization	Oracle Corporation
User-Agent	Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
MIME-Version	1.0
Content-Type	text/plain
X-Source-IP	userv0022.oracle.com [156.151.31.74]
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	20
X-Original-Cc	James Bottomley <James.Bottomley@HansenPartnership.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, Tomas Henzl <thenzl@redhat.com>, Johannes Thumshirn <jthumshirn@suse.de>, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Wed, 06 Jan 2016 15:29:03 -0500
X-Original-Message-ID	<yq1y4c2ih9s.fsf@sermon.lab.mkp.net>
X-Original-References	<1451995000-9210-1-git-send-email-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1303041

Show key headers only | View raw

>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:

Colin,

Colin> The return code and error return is incorrectly indented which
Colin> may cause some confusion as it appears at first sight to be
Colin> associated with a device not ready error (with missing { }
Colin> braces) rather than a DEV_IS_GONE() failure.

This problem has already been addressed:

https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: mvsas: fix indenting on return error code Colin King <colin.king@canonical.com> - 2016-01-05 13:00 +0100
  Re: [PATCH] scsi: mvsas: fix indenting on return error code Tomas Henzl <thenzl@redhat.com> - 2016-01-05 13:40 +0100
  Re: [PATCH] scsi: mvsas: fix indenting on return error code "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-06 21:30 +0100

csiph-web