Re: [PATCH] scsi: mvsas: fix indenting on return error code

From	"Martin K. Petersen" <martin.petersen@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scsi: mvsas: fix indenting on return error code
Date	2016-01-06 21:30 +0100
Message-ID	<qO2Su-5Zm-17@gated-at.bofh.it> (permalink)
References	<qNyro-2dj-9@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:

Colin,

Colin> The return code and error return is incorrectly indented which
Colin> may cause some confusion as it appears at first sight to be
Colin> associated with a device not ready error (with missing { }
Colin> braces) rather than a DEV_IS_GONE() failure.

This problem has already been addressed:

https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c

-- 
Martin K. Petersen	Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: mvsas: fix indenting on return error code Colin King <colin.king@canonical.com> - 2016-01-05 13:00 +0100
  Re: [PATCH] scsi: mvsas: fix indenting on return error code Tomas Henzl <thenzl@redhat.com> - 2016-01-05 13:40 +0100
  Re: [PATCH] scsi: mvsas: fix indenting on return error code "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-06 21:30 +0100

csiph-web