[PATCH] scsi: mvsas: fix indenting on return error code

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] scsi: mvsas: fix indenting on return error code
Date	2016-01-05 13:00 +0100
Message-ID	<qNyro-2dj-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The return code and error return is incorrectly indented which
may cause some confusion as it appears at first sight to be associated
with a device not ready error (with missing { } braces) rather than
a DEV_IS_GONE() failure.

The incorrect indenting was introduced by commit
0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
for Task collector mode and fixed relative bugs")

No functional change, just a minor code reformatting clean up.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/scsi/mvsas/mv_sas.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 9c78074..e712fe7 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
 			mv_dprintk("device %016llx not ready.\n",
 				SAS_ADDR(dev->sas_addr));
 
-			rc = SAS_PHY_DOWN;
-			return rc;
+		rc = SAS_PHY_DOWN;
+		return rc;
 	}
 	tei.port = dev->port->lldd_port;
 	if (tei.port && !tei.port->port_attached && !tmf) {
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi: mvsas: fix indenting on return error code Colin King <colin.king@canonical.com> - 2016-01-05 13:00 +0100
  Re: [PATCH] scsi: mvsas: fix indenting on return error code Tomas Henzl <thenzl@redhat.com> - 2016-01-05 13:40 +0100
  Re: [PATCH] scsi: mvsas: fix indenting on return error code "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-06 21:30 +0100

csiph-web