Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1301470 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-01-05 13:00 +0100 |
| Last post | 2016-01-06 21:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] scsi: mvsas: fix indenting on return error code Colin King <colin.king@canonical.com> - 2016-01-05 13:00 +0100
Re: [PATCH] scsi: mvsas: fix indenting on return error code Tomas Henzl <thenzl@redhat.com> - 2016-01-05 13:40 +0100
Re: [PATCH] scsi: mvsas: fix indenting on return error code "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-01-06 21:30 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-01-05 13:00 +0100 |
| Subject | [PATCH] scsi: mvsas: fix indenting on return error code |
| Message-ID | <qNyro-2dj-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The return code and error return is incorrectly indented which
may cause some confusion as it appears at first sight to be associated
with a device not ready error (with missing { } braces) rather than
a DEV_IS_GONE() failure.
The incorrect indenting was introduced by commit
0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
for Task collector mode and fixed relative bugs")
No functional change, just a minor code reformatting clean up.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/mvsas/mv_sas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_sas.c b/drivers/scsi/mvsas/mv_sas.c
index 9c78074..e712fe7 100644
--- a/drivers/scsi/mvsas/mv_sas.c
+++ b/drivers/scsi/mvsas/mv_sas.c
@@ -737,8 +737,8 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
mv_dprintk("device %016llx not ready.\n",
SAS_ADDR(dev->sas_addr));
- rc = SAS_PHY_DOWN;
- return rc;
+ rc = SAS_PHY_DOWN;
+ return rc;
}
tei.port = dev->port->lldd_port;
if (tei.port && !tei.port->port_attached && !tmf) {
--
2.6.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Tomas Henzl <thenzl@redhat.com> |
|---|---|
| Date | 2016-01-05 13:40 +0100 |
| Message-ID | <qNz46-2Jv-9@gated-at.bofh.it> |
| In reply to | #1301470 |
On 5.1.2016 12:56, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The return code and error return is incorrectly indented which
> may cause some confusion as it appears at first sight to be associated
> with a device not ready error (with missing { } braces) rather than
> a DEV_IS_GONE() failure.
>
> The incorrect indenting was introduced by commit
> 0b15fb1fdfd403726542cb6111bc916b7a9f7fad ("[SCSI] mvsas: add support
> for Task collector mode and fixed relative bugs")
>
> No functional change, just a minor code reformatting clean up.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | "Martin K. Petersen" <martin.petersen@oracle.com> |
|---|---|
| Date | 2016-01-06 21:30 +0100 |
| Message-ID | <qO2Su-5Zm-17@gated-at.bofh.it> |
| In reply to | #1301470 |
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin,
Colin> The return code and error return is incorrectly indented which
Colin> may cause some confusion as it appears at first sight to be
Colin> associated with a device not ready error (with missing { }
Colin> braces) rather than a DEV_IS_GONE() failure.
This problem has already been addressed:
https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web