Path: csiph.com!au2pb.net!2.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!eternal-september.org!feeder.eternal-september.org!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod From: "Martin K. Petersen" Newsgroups: linux.kernel Subject: Re: [PATCH] scsi: mvsas: fix indenting on return error code Date: Wed, 06 Jan 2016 21:30:02 +0100 Message-ID: References: X-Original-To: Colin King Organization: Oracle Corporation User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 20 X-Original-Cc: James Bottomley , "Martin K . Petersen" , Tomas Henzl , Johannes Thumshirn , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org X-Original-Date: Wed, 06 Jan 2016 15:29:03 -0500 X-Original-Message-ID: X-Original-References: <1451995000-9210-1-git-send-email-colin.king@canonical.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1303041 >>>>> "Colin" == Colin King writes: Colin, Colin> The return code and error return is incorrectly indented which Colin> may cause some confusion as it appears at first sight to be Colin> associated with a device not ready error (with missing { } Colin> braces) rather than a DEV_IS_GONE() failure. This problem has already been addressed: https://git.kernel.org/cgit/linux/kernel/git/mkp/scsi.git/commit/?h=4.5/scsi-queue&id=7789cd39274c -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/